Codecov Report

All modified lines are covered by tests ✅

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@boks1971 - immediately after the lines of code you've changed is this:

// set missing packets as missing
for i := stream.lastSeqnum + 1; i != pktHeader.SequenceNumber; i++ {
	stream.delReceived(i)
}

I may be having a real bad code comprehension day, but this doesn't seem right. pktHeader.SequenceNumber is the 'non-unwrapped' sequence number, so if for example we have the packet sequence 65533, 65534, 3, 4, 5, ... then when we receive packet with sequence number 3, stream.lastSeqnum will be 65534, pktHeader.SequenceNumber will be 3 and so the for loop won't execute at all, and we won't call delReceived on the missing packets 65535, 0, 1, 2.

Don't we need something like this instead?

for i := uint32(stream.lastSeqnum) + 1; i != uint32(stream.seqnumCycles)<<16 | uint32(stream.lastSeqnum); i++ {

@boks1971 - immediately after the lines of code you've changed is this:

// set missing packets as missing
for i := stream.lastSeqnum + 1; i != pktHeader.SequenceNumber; i++ {
	stream.delReceived(i)
}

I may be having a real bad code comprehension day, but this doesn't seem right. pktHeader.SequenceNumber is the 'non-unwrapped' sequence number, so if for example we have the packet sequence 65533, 65534, 3, 4, 5, ... then when we receive packet with sequence number 3, stream.lastSeqnum will be 65534, pktHeader.SequenceNumber will be 3 and so the for loop won't execute at all, and we won't call delReceived on the missing packets 65535, 0, 1, 2.

Don't we need something like this instead?

for i := uint32(stream.lastSeqnum) + 1; i != uint32(stream.seqnumCycles)<<16 | uint32(stream.lastSeqnum); i++ {

It should be fine @adriancable as the types are uint16. i will be uint16 and looping over it means it will loop through 65535, 0, 1, 2. That pattern is used in a lot of places for wrap around handling.

@boks1971 - you are absolutely right of course! Thank you for fixing my bad code comprehension day. :-)